hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1527) QueueManager should issue warning if mapred-queues.xml is skipped.
Date Wed, 24 Feb 2010 21:57:28 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838014#action_12838014
] 

Hadoop QA commented on MAPREDUCE-1527:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12436883/mr-1527-20100224-2.patch
  against trunk revision 915223.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/481/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/481/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/481/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/481/console

This message is automatically generated.

> QueueManager should issue warning if mapred-queues.xml is skipped.
> ------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1527
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1527
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Hong Tang
>            Assignee: Hong Tang
>         Attachments: mr-1527-20100224-2.patch, mr-1527-20100224.patch
>
>
> MAPREDUCE-861 added support for hierarchical queues and used a new file mapred-queues.xml
to configure queues. But the QueueManager will silently skip the file if property "mapred.queue.names"
is defined in Configuration. This tripped us when we are testing MAPREDUCE-1235 and copied
configuration files from a Hadoop 0.20 cluster.
> I suggest QueueManager issue a friendly warning if both of the following are true: (1)
"mapred.queue.names" exists in Configuration; (2) "mapred-queues.xml" is found in the classpath.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message