hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amareshwari Sriramadasu (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1371) TaskTracker.offerService catches exceptions and ignores.
Date Tue, 12 Jan 2010 06:08:54 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12799087#action_12799087
] 

Amareshwari Sriramadasu commented on MAPREDUCE-1371:
----------------------------------------------------


Offending code here, 
{code}
  State offerService() throws Exception {
    while (running && !shuttingDown) {
      try {
        ...
        ...
      } catch (...) {
      } catch (Exception except) {
        String msg = "Caught exception: " + 
          StringUtils.stringifyException(except);
        LOG.error(msg);
      }
    }
  }
{code}

This is seen on some test failures. See test timeout on MAPREDUCE-1365

> TaskTracker.offerService catches exceptions and ignores.
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-1371
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1371
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tasktracker
>    Affects Versions: 0.20.1
>            Reporter: Amareshwari Sriramadasu
>             Fix For: 0.21.0
>
>
> TaskTracker.offerService() code catches exceptions and just logs it. Instead it should
throw it out.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message