Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Message-ID: <816055971.1261485509525.JavaMail.jira@brutus>
Date: Tue, 22 Dec 2009 12:38:29 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Subject: [jira] Commented: (MAPREDUCE-1320) StringBuffer -> StringBuilder
 occurence
In-Reply-To: <816847958.1261441458078.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793603#action_12793603 ] 

Hadoop QA commented on MAPREDUCE-1320:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12428677/MAPREDUCE-1320.patch
  against trunk revision 893055.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/332/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/332/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/332/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/332/console

This message is automatically generated.

> StringBuffer -> StringBuilder occurence 
> ----------------------------------------
>
>                 Key: MAPREDUCE-1320
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1320
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 0.20.1
>            Reporter: Kay Kay
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1320.patch
>
>
> A good number of toString() implementations use StringBuffer when the reference clearly does not go out of scope of the method and no concurrency is needed. Patch contains replacing those occurences from StringBuffer to StringBuilder. 
> Created against map/reduce project trunk . 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.