Return-Path: Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: (qmail 38366 invoked from network); 8 Dec 2009 22:13:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 8 Dec 2009 22:13:41 -0000 Received: (qmail 84015 invoked by uid 500); 8 Dec 2009 22:13:41 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 83963 invoked by uid 500); 8 Dec 2009 22:13:41 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 83953 invoked by uid 99); 8 Dec 2009 22:13:41 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Dec 2009 22:13:41 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Dec 2009 22:13:39 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 22CD5234C04C for ; Tue, 8 Dec 2009 14:13:18 -0800 (PST) Message-ID: <656192856.1260310398127.JavaMail.jira@brutus> Date: Tue, 8 Dec 2009 22:13:18 +0000 (UTC) From: "Hadoop QA (JIRA)" To: mapreduce-issues@hadoop.apache.org Subject: [jira] Commented: (MAPREDUCE-1174) Sqoop improperly handles table/column names which are reserved sql words In-Reply-To: <943240287.1256954339469.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MAPREDUCE-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787775#action_12787775 ] Hadoop QA commented on MAPREDUCE-1174: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12427372/MAPREDUCE-1174.3.patch against trunk revision 888431. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/174/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/174/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/174/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/174/console This message is automatically generated. > Sqoop improperly handles table/column names which are reserved sql words > ------------------------------------------------------------------------ > > Key: MAPREDUCE-1174 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1174 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: contrib/sqoop > Reporter: Aaron Kimball > Assignee: Aaron Kimball > Attachments: MAPREDUCE-1174.2.patch, MAPREDUCE-1174.3.patch, MAPREDUCE-1174.patch > > > In some databases it is legal to name tables and columns with terms that overlap SQL reserved keywords (e.g., {{CREATE}}, {{table}}, etc.). In such cases, the database allows you to escape the table and column names. We should always escape table and column names when possible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.