Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Message-ID: <626212887.1262202989414.JavaMail.jira@brutus.apache.org>
Date: Wed, 30 Dec 2009 19:56:29 +0000 (UTC)
From: "Todd Lipcon (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Subject: [jira] Commented: (MAPREDUCE-1155) Streaming tests swallow
 exceptions
In-Reply-To: <853022371.1256583179466.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795416#action_12795416 ] 

Todd Lipcon commented on MAPREDUCE-1155:
----------------------------------------

Yes, I elected to do the cleanup in the setup method as a bandaid - I couldn't figure out which tests were leaving junk lying around, so I did the recursive delete at the start. I also sometimes find this technique to be handy since the developer can investigate the state of the test directory after the test has failed. If there's a tearDown method, the state that contained the failure is gone by the time the developer sees that the test failed.

bq. Also this patch seems to address more than one issue at hand.

Yep - once I fixed the original issue (swallowing exceptions) I found that some of the tests had been failing before and no one ever knew, so I had to go and fix those as well.

> Streaming tests swallow exceptions
> ----------------------------------
>
>                 Key: MAPREDUCE-1155
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1155
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/streaming
>    Affects Versions: 0.20.1, 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: mapreduce-1155.patch, mapreduce-1155.patch, mapreduce-1155.txt, mapreduce-1155.txt
>
>
> Many of the streaming tests (including TestMultipleArchiveFiles) catch exceptions and print their stack trace rather than failing the job. This means that tests do not fail even when the job fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.