Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Message-ID: <220164778.1260225018713.JavaMail.jira@brutus>
Date: Mon, 7 Dec 2009 22:30:18 +0000 (UTC)
From: "Aaron Kimball (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Subject: [jira] Commented: (MAPREDUCE-1097) Changes/fixes to support Vertica
 3.5
In-Reply-To: <1086964512.1255403251419.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787176#action_12787176 ] 

Aaron Kimball commented on MAPREDUCE-1097:
------------------------------------------

Omer,

The gridmix failure is a known bug elsewhere in Hadoop; that's unrelated to this patch.

As for the rest of the code you posted...

VerticaOutputFormat:

* make a constant {{VERSION_3_5 = 305}} in VerticaUtil?
* "pool for refresh complete" -> "poll..."
* You select table_name, projection_name, and status from vt_projection_refresh, but you never seem to read projection_name from the ResultSet. Is this intentional?
* Also, I think you should call ResultSet.close() before calling the next stmt.executeQuery()
* Related, at the end of the function, I think you may want to call stmt.close() to ensure that all those resources are freed before continuing on.
* What's an "ahm" ? (Add to source comment?)

VerticaRecord:

* line 378: no need to cast to BigDecimal before calling toString
* It looks like REAL, DECIMAL, and NUMERIC used to be treated as doubles in Java, and are now treated as BigDecimal. Is this correct? If so, what happens to existing data (e.g., serialized into SequenceFiles) that contains data of this type? Is this an incompatible change?
* It also looks as though you are changing how nulls are handled. Is this backwards compatible with existing VerticaRecord deployments?
* line 575: unnecessary cast to BigDecimal.


> Changes/fixes to support Vertica 3.5
> ------------------------------------
>
>                 Key: MAPREDUCE-1097
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1097
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 0.21.0
>         Environment: Hadoop 0.21.0 pre-release and Vertica 3.5
>            Reporter: Omer Trajman
>            Assignee: Omer Trajman
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1097.patch
>
>
> Vertica 3.5 includes three changes that the formatters should handle:
> 1) deploy_design function that handles much of the logic in the optimize method.  This improvement uses deploy_design if the server version supports it instead of orchestrating in the formatter function.
> 2) truncate table instead of recreating the table
> 3) numeric, decimal, money, number types (all the same path)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.