hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1343) Scope Change - FileOutputCommitter # SUCCESSFUL_JOB_OUTPUT_DIR_MARKER, package default to public
Date Wed, 30 Dec 2009 00:16:29 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795204#action_12795204
] 

Hadoop QA commented on MAPREDUCE-1343:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12429089/MAPREDUCE-1343.patch
  against trunk revision 894165.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/244/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/244/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/244/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/244/console

This message is automatically generated.

> Scope Change - FileOutputCommitter # SUCCESSFUL_JOB_OUTPUT_DIR_MARKER, package default
to public 
> -------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1343
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1343
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Kay Kay
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1343.patch
>
>
> Being a configuration property - it should be public static for apps to set /reset the
property as opposed to hardcoding the string. 
> Scope changed from package default to public. 
> Also - enhanced with javadocs around the same. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message