hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matei Zaharia (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-698) Per-pool task limits for the fair scheduler
Date Wed, 02 Dec 2009 06:00:21 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784645#action_12784645
] 

Matei Zaharia commented on MAPREDUCE-698:
-----------------------------------------

The patch looks good to me. The only other thing I'd ask for is some documentation of what
happens if a pool's max share is set to lower than its min share. The best way to do this
might be to log a warning using LOG.warn before the "commit" part of PoolManager.reloadAllocs
and say that when a pool's max share is lower than its min share, the max share takes precedence.
You could also display this warning on the web UI when pools with max share < min share
exist, because admins are likely to be looking at the UI after they modify their config file.

The unit test failures seem to be unrelated to the patch - in particular, the one in the fair
scheduler is due to MAPREDUCE-1245.

> Per-pool task limits for the fair scheduler
> -------------------------------------------
>
>                 Key: MAPREDUCE-698
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-698
>             Project: Hadoop Map/Reduce
>          Issue Type: New Feature
>          Components: contrib/fair-share
>            Reporter: Matei Zaharia
>            Assignee: Kevin Peterson
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-698-prelim.patch, mapreduce-698-trunk-3.patch, mapreduce-698-trunk.patch,
mapreduce-698-trunk.patch
>
>
> The fair scheduler could use a way to cap the share of a given pool similar to MAPREDUCE-532.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message