hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kay Kay (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1155) Streaming tests swallow exceptions
Date Wed, 30 Dec 2009 20:10:29 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795424#action_12795424

Kay Kay commented on MAPREDUCE-1155:

Yes, I elected to do the cleanup in the setup method as a bandaid - I couldn't figure out
which tests were leaving junk lying around, so I did the recursive delete at the start. I
also sometimes find this technique to be handy since the developer can investigate the state
of the test directory after the test has failed. If there's a tearDown method, the state that
contained the failure is gone by the time the developer sees that the test failed. 

I would vote for a failure of tearDown method by a given test case , so when I see a batch
of test failures , after a tearDown failure - I can make a reasonable assumption that there
is only 1 base issue that we are concerned about , and the rest may be bogus.  Case in point:
I was trying to TestStreamingExitStatus / TestStreamingKeyValue test cases. The former did
not have a proper cleanup , while the latter failed because of the same. It took me quite
 a lot of time before concluding that the latter does not have any issue by itself except
for incorrect test fixture assumptions.

But as I said - this is something that can be taken up in a separate bug - but given that
this patch seems to make the build green and address the primary issue of swallowing exceptions
I would say - go ahead and commit this while we discuss the fixtures in a separate bug altogether.

> Streaming tests swallow exceptions
> ----------------------------------
>                 Key: MAPREDUCE-1155
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1155
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/streaming
>    Affects Versions: 0.20.1, 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: mapreduce-1155.patch, mapreduce-1155.patch, mapreduce-1155.txt,
> Many of the streaming tests (including TestMultipleArchiveFiles) catch exceptions and
print their stack trace rather than failing the job. This means that tests do not fail even
when the job fails.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message