hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "rahul k singh (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1067) Default state of queues is undefined when unspecified
Date Thu, 17 Dec 2009 06:32:18 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791808#action_12791808
] 

rahul k singh commented on MAPREDUCE-1067:
------------------------------------------

some very minor nits:
QueueConfigurationParser.java
1.     if (queueState != null && !(children != null && children.size() >
0)) {
       queueState != null check

QueueState.java

Instead of comment " i    //we are passing uppercase , as java returns the respective case
enum object 
    //so for "stopped" valueOf returns the lowercase enum "stopped" object.
"
We should say " We are passing uppercase , as according to javadoc for valueOf"The name must
match exactly an identifier used to declare an enum constant in this type. (Extraneous whitespace
characters are not permitted.)"

--My initial comment wasnt very correct.

Queue.java
1. In the statement 
"throw new IllegalStateException(this.name +
        " is a container queue and cannot be set.");
     "   

It should be " is a container queue . Container queue is always in running state , and its
state cannot be overridden"

> Default state of queues is undefined when unspecified
> -----------------------------------------------------
>
>                 Key: MAPREDUCE-1067
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1067
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobtracker
>    Affects Versions: 0.21.0
>            Reporter: V.V.Chaitanya Krishna
>            Assignee: V.V.Chaitanya Krishna
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1067-1.patch, MAPREDUCE-1067-2.patch, MAPREDUCE-1067-3.patch,
MAPREDUCE-1067-4.patch, MAPREDUCE-1067-5.patch
>
>
> Currently, if the state of a queue is not specified, it is being set to "undefined" state
instead of running state.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message