hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1148) SQL identifiers are a superset of Java identifiers
Date Tue, 08 Dec 2009 22:55:18 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787793#action_12787793
] 

Hadoop QA commented on MAPREDUCE-1148:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12427371/MAPREDUCE-1148.3.patch
  against trunk revision 888431.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/304/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/304/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/304/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/304/console

This message is automatically generated.

> SQL identifiers are a superset of Java identifiers
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1148
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1148
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/sqoop
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>         Attachments: MAPREDUCE-1148.2.patch, MAPREDUCE-1148.3.patch, MAPREDUCE-1148.patch
>
>
> SQL identifiers can contain arbitrary characters, can start with numbers, can be words
like {{class}} which are reserved in Java, etc. If Sqoop uses these names literally for class
and field names then compilation errors can occur in auto-generated classes. SQL identifiers
need to be cleansed to map onto Java identifiers.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message