hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Boris Shkolnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-744) Support in DistributedCache to share cache files with other users after HADOOP-4493
Date Tue, 22 Dec 2009 19:16:29 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793743#action_12793743
] 

Boris Shkolnik commented on MAPREDUCE-744:
------------------------------------------

Some comments from review:

1. DistributedCache.get*Visibiliteies - are deprecated. Why do we add deprecated methods?
2. Do we need separate call for determineFile/ArchiveVisability. It can be determined while
calling DistributedCache.addCacheArchive/File()
3. private static isPublic() should be called differently - something like haveOtherPermissions(Perm),
to match its functionality. Some comments would help too.
4. public methods should have javadoc comments (determineCacheVisibilities() in TrackerDistributedCacheManager)
5. this line: File workDir = new File(new Path(TEST_ROOT_DIR, "workdir").toString()); 
can be changed to File workDir = new File(TEST_ROOT_DIR, "workdir") in Tasktrackerdistributedcachemanager


> Support in DistributedCache to share cache files with other users after HADOOP-4493
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-744
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-744
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: tasktracker
>            Reporter: Vinod K V
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 744-1.patch, 744-2.patch, 744-3.patch, 744-early.patch
>
>
> HADOOP-4493 aims to completely privatize the files distributed to TT via DistributedCache.
This jira issues focuses on sharing some/all of these files with all other users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message