hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hemanth Yamijala (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1140) Per cache-file refcount can become negative when tasks release distributed-cache files
Date Fri, 27 Nov 2009 08:54:39 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783062#action_12783062
] 

Hemanth Yamijala commented on MAPREDUCE-1140:
---------------------------------------------

This seems fine to me, except for small points:
- We are changing the exception thrown from getLocalCache and I don't know what kind of side
effects that has. Can we instead do something like this:
{code}
getLocalCache() {
  // get the lcacheStatus

  boolean initSuccessful = false;
  try {
    // localize, etc
    initSuccessful = true;
    return localizedPath;
  } finally {
    if (!initSuccessful) {
      synchronized (cachedArchives) {
        lcacheStatus.refcount--;
      }
    }
  }
}
{code}

This way, we do not modify the exception state at all, while still achieving the purpose.

- Another minor nit is that in the test case, testReferenceCount, we should chance the comment
"// Configures another job with two regular files." to three, a change you made w.r.to my
other review comment.

> Per cache-file refcount can become negative when tasks release distributed-cache files
> --------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1140
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1140
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tasktracker
>    Affects Versions: 0.20.2, 0.21.0, 0.22.0
>            Reporter: Vinod K V
>            Assignee: Amareshwari Sriramadasu
>         Attachments: patch-1140-1.txt, patch-1140-2.txt, patch-1140-ydist.txt, patch-1140-ydist.txt,
patch-1140.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message