hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1236) added LOG.isdebugenabled for LOG.debug() as noted in MAPREDUCE-1026
Date Mon, 23 Nov 2009 18:31:39 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781520#action_12781520
] 

Konstantin Boudnik commented on MAPREDUCE-1236:
-----------------------------------------------

While {{LOG.isDebugEnabled()}} will allow not to construct a possible complex and thus costly
message object it isn't necessary a good idea in general to use this check everywhere. Say,
if a debug message is a simple string literal then it will be created at the compile time.
Effectively, you'll end up with _two_ checks of the configured log level in such a case.

Just a reminder not to use it blindly :-)

> added LOG.isdebugenabled for LOG.debug() as noted in MAPREDUCE-1026
> -------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1236
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1236
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Boris Shkolnik
>            Priority: Minor
>
> in /MAPREDUCE-1026 we introduces few LOG.debug() not constrained by LOG.isdebugenabed()
.
> Fixing that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message