Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Message-ID: <2032643853.1256841479508.JavaMail.jira@brutus>
Date: Thu, 29 Oct 2009 18:37:59 +0000 (UTC)
From: "Allen Wittenauer (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Subject: [jira] Updated: (MAPREDUCE-1166) SerialUtils.cc: dynamic allocation
 of arrays based on runtime variable is not portable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/MAPREDUCE-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allen Wittenauer updated MAPREDUCE-1166:
----------------------------------------

    Attachment:     (was: MAPREREDUCE-1166.patch)

> SerialUtils.cc: dynamic allocation of arrays based on runtime variable is not portable
> --------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1166
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1166
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Allen Wittenauer
>         Attachments: MAPREREDUCE-1166.patch
>
>
> In SerialUtils.cc, the following code appears:
>     int len;
>     if (b < -120) {
>       negative = true;
>       len = -120 - b;
>     } else {
>       negative = false;
>       len = -112 - b;
>     }
>     uint8_t barr[len];
> as far as I'm aware, this is not legal in ANSI C and will be rejected by ANSI compliant compilers.  Instead, this should be malloc()'d based upon the size of len and free()'d later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.