hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "gary murry (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1108) Modify test-patch.sh to verify that the number of findBugs warning is always zero
Date Wed, 14 Oct 2009 17:26:31 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765652#action_12765652
] 

gary murry commented on MAPREDUCE-1108:
---------------------------------------

{quote}And to help contributors about what to do when an un-ignorable warning is spelt out
by test-patch.sh, we should modify the output of test-patch.sh to point to src/test/findbugsExcludeFile.xml
for suppressing any warnings.{quote}

I assume you meant "what to do when a warning is either not fixable or incorrect", not "un-ignorable".
 

> Modify test-patch.sh to verify that the number of findBugs warning is always zero
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1108
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1108
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>            Reporter: Vinod K V
>
> HADOOP-5661 and MAPREDUCE-769 involve going through pains to make sure findBugs warnings
become zero. All that effort would be a waste if patches keep ignoring these warnings. 
> We should modify the Hudson test-patch.sh script to always verify that the findBugs warnings
are zero in number. It should scream when the warnings go above zero level and make sure trunk
is always at zero findBugs warnings.
> And to help contributors about what to do when an un-ignorable warning is spelt out by
test-patch.sh, we should modify the output of test-patch.sh to point to _src/test/findbugsExcludeFile.xml_
for suppressing any warnings.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message