hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dick King (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1134) The API around HistoryEvent has inelegances
Date Sat, 24 Oct 2009 00:12:59 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769546#action_12769546
] 

Dick King commented on MAPREDUCE-1134:
--------------------------------------

I'm writing this comment to track other glitches I find as I work this code.

The getEventType() of a JobInfoChangeEvent is JOB_INFO_CHANGED .  Note the extra D in the
enumeral [or the lack in the class].
Ditto for JobPriorityChangeEvent.

JobUnsuccessfulCompletionEvent ==> JOB_FAILED







> The API around HistoryEvent has inelegances
> -------------------------------------------
>
>                 Key: MAPREDUCE-1134
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1134
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Dick King
>
> For example, ReduceAttemptFinishedEvent has a getAttemptId() method, but TaskAttemptStartedEvent
has a getTaskAttemptId() method.  TaskFailedEvent has a getFailedAttemptID [note that "ID"
in this context is spelled with an uppercase D, while all the other "Id"'s are spelled with
a lowercase d ] .
> Should we make a pass over these things and clean these up before too many people code
to this API?
> -dk

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message