hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hemanth Yamijala (JIRA)" <j...@apache.org>
Subject [jira] Updated: (MAPREDUCE-979) JobConf.getMemoryFor{Map|Reduce}Task doesn't fallback to newer config knobs when mapred.taskmaxvmem is set to DISABLED_MEMORY_LIMIT of -1
Date Tue, 06 Oct 2009 11:21:31 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hemanth Yamijala updated MAPREDUCE-979:
---------------------------------------

    Attachment: mapreduce-979-2.patch

The attached patch (mapreduce-979-2.patch) has some modifications I did as part of the review.
These include:

- Refactoring the code in getMemoryForMapTask, getMemoryForReduceTask and getDeprecatedMemoryValue.
Specifically the last one, I made it return only the deprecated value, or disabled value if
deprecated keys are not defined.
- Fixed a bug in getDeprecatedMemoryValue to handle normalization of the config values.
- Modified getMaxVirtualMemoryForTask to behave similarly as the new APIs. So, they return
the new values if the deprecated values are undefined.
- Updated Javadocs for the public APIs
- Added unit tests for the negative values in configuration.

Sreekanth, can you please check if these changes are fine ?

> JobConf.getMemoryFor{Map|Reduce}Task doesn't fallback to newer config knobs when mapred.taskmaxvmem
is set to DISABLED_MEMORY_LIMIT of -1
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-979
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-979
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobtracker, tasktracker
>    Affects Versions: 0.20.1
>            Reporter: Arun C Murthy
>            Priority: Blocker
>             Fix For: 0.20.2
>
>         Attachments: mapreduce-979-1-20.patch, mapreduce-979-1.patch, mapreduce-979-2.patch
>
>
> JobConf.getMemoryFor{Map|Reduce}Task doesn't fallback to newer config knobs when mapred.taskmaxvmem
is set to DISABLED_MEMORY_LIMIT of -1, this results in failed job-submissions when mapred-default.xml
has the default value of -1.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message