Return-Path: Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: (qmail 95127 invoked from network); 8 Sep 2009 15:50:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 8 Sep 2009 15:50:21 -0000 Received: (qmail 25398 invoked by uid 500); 8 Sep 2009 15:50:21 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 25337 invoked by uid 500); 8 Sep 2009 15:50:21 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 25324 invoked by uid 99); 8 Sep 2009 15:50:21 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Sep 2009 15:50:21 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Sep 2009 15:50:18 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 7803F234C044 for ; Tue, 8 Sep 2009 08:49:57 -0700 (PDT) Message-ID: <973397031.1252424997483.JavaMail.jira@brutus> Date: Tue, 8 Sep 2009 08:49:57 -0700 (PDT) From: "Ravi Gummadi (JIRA)" To: mapreduce-issues@hadoop.apache.org Subject: [jira] Commented: (MAPREDUCE-644) distcp does not skip copying file if we are updating single file MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MAPREDUCE-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752582#action_12752582 ] Ravi Gummadi commented on MAPREDUCE-644: ---------------------------------------- I tested it manually and I see that the single file's copy is skipped only with the patch. Am wondering if we can verify the count of files copied(there is a counter 'COPY' in distcp for this) from testcase after running distcp for a single file with -update option and the destination contains the file already. Thoughts ? > distcp does not skip copying file if we are updating single file > ---------------------------------------------------------------- > > Key: MAPREDUCE-644 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-644 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: distcp > Reporter: Ravi Gummadi > Assignee: Ravi Gummadi > Attachments: d_singlefile_update.patch > > > distcp doesn't skip copying file when we do -update on single file if the destfile already exists. > When we do > hadoop distcp -update srcfilename destfilename > it seems to be comparing checksums of srcfilename and destfilename/srcfilename and so skip is not done. It should compare checksums of srcfilename and destfilename. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.