Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Message-ID: <2043510473.1253300477660.JavaMail.jira@brutus>
Date: Fri, 18 Sep 2009 12:01:17 -0700 (PDT)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Subject: [jira] Commented: (MAPREDUCE-990) Making distributed cache getters
 in JobContext never return null
In-Reply-To: <591120828.1253122557588.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757352#action_12757352 ] 

Hadoop QA commented on MAPREDUCE-990:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12420045/MAPREDUCE-990.patch
  against trunk revision 816735.

    -1 @author.  The patch appears to contain  @author tags which the Hadoop community has agreed to not allow in code contributions.

    +1 tests included.  The patch appears to include  new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/114/console

This message is automatically generated.

> Making distributed cache getters in JobContext never return null
> ----------------------------------------------------------------
>
>                 Key: MAPREDUCE-990
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Philip Zeyliger
>            Assignee: Philip Zeyliger
>            Priority: Minor
>         Attachments: MAPREDUCE-990.patch, MAPREDUCE-990.patch.txt
>
>
> MAPREDUCE-898 moved distributed cache setters and getters into Job and JobContext.  Since the API is new, I'd like to propose that those getters never return null, but instead always return an array, even if it's empty.
> If people don't like this change, I can instead merely update the javadoc to reflect the fact that null may be returned.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.