hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun C Murthy (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-954) The new interface's Context objects should be interfaces
Date Wed, 16 Sep 2009 15:41:58 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756084#action_12756084
] 

Arun C Murthy commented on MAPREDUCE-954:
-----------------------------------------

bq. I don't see how MapperImpl is actually used. A user-supplied Mapper extends Mapper, not
MapperImpl, so I'm missing how the concrete context is actually created.

That's the *nearly* complete part... apologies, I should have clarified this. *smile*

I need to wire it in with a {Mapper|Reducer}Impl.createContext and use it from within the
framework. 

bq. The getProgressible() method of JobContext is misspelled 

Unfortunately I had to carry over the typo from current code - I just converted the existing
org.apache.hadoop.mapred.JobContext to an interface as-is for compatibility.

> The new interface's Context objects should be interfaces
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-954
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-954
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: client
>            Reporter: Owen O'Malley
>            Assignee: Arun C Murthy
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-954.patch, MAPREDUCE-954.patch
>
>
> When I was doing HADOOP-1230, I was persuaded to make the Context objects as classes.
I think that was a serious mistake. It caused a lot of information leakage into the public
classes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message