hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-648) distcp -update launches job when there is at least one dir in source paths to be copied, even though there is nothing to copy
Date Tue, 15 Sep 2009 20:23:57 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755674#action_12755674
] 

Hadoop QA commented on MAPREDUCE-648:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12419610/d_648_644.patch
  against trunk revision 815249.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/80/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/80/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/80/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/80/console

This message is automatically generated.

> distcp -update launches job when there is at least one dir in source paths to be copied,
even though there is nothing to copy
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-648
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-648
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: distcp
>            Reporter: Ravi Gummadi
>            Assignee: Ravi Gummadi
>            Priority: Minor
>         Attachments: d_648_644.patch, d_dirCount648.patch, d_dirCount648.v1.patch, d_dirCount_648.patch
>
>
> distcp -update launches job when there is at least one dir in source paths to be copied,
even though there is nothing to copy.
> HADOOP-5675 added fileCount > 0 to be checked to decide whether to launch job. And
HADOOP-5762 changed this to fileCount + dirCount > 0 to solve the issue of empty directories
not getting copied to destination. With -update, dirCount is incremented without checking
if that dir already exists at the destination. So distcp job is launched because of dirCount
> 0 even though there is nothing to copy. Incrementing dirCount can be skipped if that
dir already exists at the destination in case of -update.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message