hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-852) ExampleDriver is incorrectly set as a Main-Class in tools in build.xml
Date Fri, 14 Aug 2009 22:57:14 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743482#action_12743482

Hadoop QA commented on MAPREDUCE-852:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 804284.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/476/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/476/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/476/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/476/console

This message is automatically generated.

> ExampleDriver is incorrectly set as a Main-Class in tools in build.xml
> ----------------------------------------------------------------------
>                 Key: MAPREDUCE-852
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-852
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: m852_20090812.patch
> In build.xml,
> {code}
>   <target name="examples" depends="jar, compile-examples" description="Make the Hadoop
examples jar.">
> ...
>   <target name="tools-jar" depends="jar, compile-tools" 
>           description="Make the Hadoop tools jar.">
>     <jar jarfile="${build.dir}/${tools.final.name}.jar"
>          basedir="${build.tools}">
>       <manifest>
>         <attribute name="Main-Class" 
>                    value="org/apache/hadoop/examples/ExampleDriver"/>
>       </manifest>
>     </jar>
>   </target>
> {code}
> - ExampleDriver should not be a Main-Class of tools
> - Should we rename the target name from "tools-jar" to "tools", so that the name would
be consistent with the "examples" target?

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message