hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-808) Buffer objects incorrectly serialized to typed bytes
Date Mon, 03 Aug 2009 13:41:15 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738342#action_12738342
] 

Hadoop QA commented on MAPREDUCE-808:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12414618/MAPREDUCE-808.patch
  against trunk revision 800329.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/436/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/436/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/436/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/436/console

This message is automatically generated.

> Buffer objects incorrectly serialized to typed bytes
> ----------------------------------------------------
>
>                 Key: MAPREDUCE-808
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-808
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/streaming
>    Affects Versions: 0.21.0
>            Reporter: Klaas Bosteels
>            Assignee: Klaas Bosteels
>         Attachments: MAPREDUCE-808.patch
>
>
> {{TypedBytesOutput.write()}} should do something like
> {code}
> Buffer buf = (Buffer) obj;
> writeBytes(buf.get(), 0, bug.getCount());
> {code}
> instead of
> {code}
> writeBytes(((Buffer) obj).get());
> {code}
> since the bytes returned by {{Buffer.get()}} are "only valid between 0 and getCount()
- 1".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message