Return-Path: Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: (qmail 30745 invoked from network); 22 Jul 2009 16:32:33 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 22 Jul 2009 16:32:33 -0000 Received: (qmail 76774 invoked by uid 500); 22 Jul 2009 16:33:39 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 76729 invoked by uid 500); 22 Jul 2009 16:33:39 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 76719 invoked by uid 99); 22 Jul 2009 16:33:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jul 2009 16:33:39 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jul 2009 16:33:35 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id C7B8A234C004 for ; Wed, 22 Jul 2009 09:33:14 -0700 (PDT) Message-ID: <2043176045.1248280394803.JavaMail.jira@brutus> Date: Wed, 22 Jul 2009 09:33:14 -0700 (PDT) From: "Hemanth Yamijala (JIRA)" To: mapreduce-issues@hadoop.apache.org Subject: [jira] Commented: (MAPREDUCE-766) Enhance -list-blacklisted-trackers to display host name, blacklisted reason and blacklist report. In-Reply-To: <1194222982.1247713154754.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MAPREDUCE-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734183#action_12734183 ] Hemanth Yamijala commented on MAPREDUCE-766: -------------------------------------------- Looking good. A few minor points: - We are changing the way we print information about blacklisted trackers. Does this need to be backwards compatible ? Similarly, maybe we need not deprecate getBlacklistedTrackerNames() - The print format should be parse friendly. We are adding white space to separate reasons for blacklisting and the report can have newlines. These will make it difficult to parse. Can we make these comma separated ? - getBlackListedTracker should be getBlackListedTrackers. Similarly getBlackListedTrackerInfo() should be getBlackListedTrackersInfo() - the former seems like it is for a specific tracker. - The test class is not applying, possibly due to the commit of MAPREDUCE-682. Also, can you enhance the test case to test for a condition when no nodes are blacklisted, and when there is more than one reason to blacklist ? Maybe one of the trackers can be blacklisted for more than one reason. > Enhance -list-blacklisted-trackers to display host name, blacklisted reason and blacklist report. > ------------------------------------------------------------------------------------------------- > > Key: MAPREDUCE-766 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-766 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Reporter: Sreekanth Ramakrishnan > Assignee: Sreekanth Ramakrishnan > Attachments: mapreduce-766-1.patch, mapreduce-766-2.patch, mapreduce-766-3.patch > > > Currently, the -list-blacklisted-trackers in the mapred job option list only tracker name. We should enhance it to display as hostname, reason for blacklisting and blacklist report. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.