hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-714) JobConf.findContainingJar unescapes unnecessarily on Linux
Date Wed, 08 Jul 2009 17:19:15 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728804#action_12728804
] 

Todd Lipcon commented on MAPREDUCE-714:
---------------------------------------

Owen: that's the only difference I know of that's mentioned in the spec: http://www.w3.org/MarkUp/html-spec/html-spec_8.html#SEC8.2.1

I spent about 4 hours trying to find a portable non-klugey fix. The trouble is that the behavior
is different on Windows compared to Linux. On a Windows JVM, it encodes spaces as "%20" and
+s as "%2B" and on Linux it does neither, best I can tell.

I definitely agree that this fix is not optimal, but I think '+' is the most common case for
a "weird" character in a JAR name. In Debian and RPM packages, the non-alphanumeric characters
allowed in version numbers are [+-~.:] and I think all of those should be fine after this
patch.

> JobConf.findContainingJar unescapes unnecessarily on Linux
> ----------------------------------------------------------
>
>                 Key: MAPREDUCE-714
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-714
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Todd Lipcon
>
> In JobConf.findContainingJar, the path name is decoded using URLDecoder.decode(...).
This was done by Doug in r381794 (commit msg "Un-escape containing jar's path, which is URL-encoded.
 This fixes things primarily on Windows, where paths are likely to contain spaces.") Unfortunately,
jar paths do not appear to be URL encoded on Linux. If you try to use "hadoop jar" on a jar
with a "+" in it, this function decodes it to a space and then the job cannot be submitted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message