hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-742) Improve the java comments for the π examples
Date Fri, 10 Jul 2009 22:49:15 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729875#action_12729875
] 

Tsz Wo (Nicholas), SZE commented on MAPREDUCE-742:
--------------------------------------------------

{noformat}
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified
tests.
     [exec]                         Please justify why no new tests are needed for this patch.
     [exec]                         Also please list what manual steps were performed to verify
this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
{noformat}
The patch are mostly documentation changes.  The code changes are all related to output messages.
 So I did not add new unit tests.

Tested Util.millis2String(long) manually as shown below:
{code}
  public static void main(String[] args) {
    long n = (1L << 32) - 1;
    System.out.println(Util.millis2String(n));
  }
{code}
Before the patch, the output is "49 days 17:02:47.-01"  which is incorrect.
After the patch, the correct value, "49 days 17:02:47.295", is printed.


> Improve the java comments for the π examples
> --------------------------------------------
>
>                 Key: MAPREDUCE-742
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-742
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: documentation, examples
>    Affects Versions: 0.21.0
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: m742_20090708.patch, m742_20090709.patch, m742_20090710.patch
>
>
> There are 3 examples, pi, bbp and distbbp for &pi; computation.  We should tell the
difference between them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message