hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-680) Reuse of Writable objects is improperly handled by MRUnit
Date Fri, 10 Jul 2009 00:04:14 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729463#action_12729463
] 

Hadoop QA commented on MAPREDUCE-680:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12412118/MAPREDUCE-680.patch
  against trunk revision 792613.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 5 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/369/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/369/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/369/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/369/console

This message is automatically generated.

> Reuse of Writable objects is improperly handled by MRUnit
> ---------------------------------------------------------
>
>                 Key: MAPREDUCE-680
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-680
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>         Attachments: MAPREDUCE-680.patch
>
>
> As written, MRUnit's MockOutputCollector simply stores references to the objects passed
in to its collect() method. Thus if the same Text (or other Writable) object is reused as
an output containiner multiple times with different values, these separate values will not
all be collected. MockOutputCollector needs to properly use io.serializations to deep copy
the objects sent in.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message