Return-Path: X-Original-To: apmail-hadoop-mapreduce-dev-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7628FDD33 for ; Wed, 26 Sep 2012 17:55:30 +0000 (UTC) Received: (qmail 42803 invoked by uid 500); 26 Sep 2012 17:55:26 -0000 Delivered-To: apmail-hadoop-mapreduce-dev-archive@hadoop.apache.org Received: (qmail 42476 invoked by uid 500); 26 Sep 2012 17:55:26 -0000 Mailing-List: contact mapreduce-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-dev@hadoop.apache.org Delivered-To: mailing list mapreduce-dev@hadoop.apache.org Received: (qmail 42391 invoked by uid 99); 26 Sep 2012 17:55:26 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Sep 2012 17:55:26 +0000 X-ASF-Spam-Status: No, hits=3.3 required=5.0 tests=HTML_MESSAGE,NO_RDNS_DOTCOM_HELO,RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 98.139.253.105 is neither permitted nor denied by domain of evans@yahoo-inc.com) Received: from [98.139.253.105] (HELO mrout2-b.corp.bf1.yahoo.com) (98.139.253.105) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Sep 2012 17:55:18 +0000 Received: from SP1-EX07CAS04.ds.corp.yahoo.com (sp1-ex07cas04.corp.sp1.yahoo.com [216.252.116.155]) by mrout2-b.corp.bf1.yahoo.com (8.14.4/8.14.4/y.out) with ESMTP id q8QHsZb6051119; Wed, 26 Sep 2012 10:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yahoo-inc.com; s=cobra; t=1348682076; bh=ooLj4V3P+htWu6Np9pBDBiV0eLuYcPyvHKNpNWw5z6M=; h=From:To:CC:Date:Subject:Message-ID:In-Reply-To:Content-Type: MIME-Version; b=NmGjfi6sCDP8jwJ9HRUv+MotrwwJSLqEAPhbMTsSUP2X2j2xEcv9rR710OSr+pyHZ 5k/D7IzXgrFusvuEMOtP3RwTo/Yd+15b3oriLysLKfoyV6VBs6ftw+br9Wgy6e3Sfi /zzJJOF7OoAhvtJjc3QC3QvZcgxrCjjWY0fgwiI0= Received: from SP1-EX07VS02.ds.corp.yahoo.com ([216.252.116.135]) by SP1-EX07CAS04.ds.corp.yahoo.com ([216.252.116.158]) with mapi; Wed, 26 Sep 2012 10:54:34 -0700 From: Robert Evans To: Arun C Murthy , "hdfs-dev@hadoop.apache.org" CC: "common-dev@hadoop.apache.org" , "yarn-dev@hadoop.apache.org" , "mapreduce-dev@hadoop.apache.org" Date: Wed, 26 Sep 2012 10:54:31 -0700 Subject: Re: Commits breaking compilation of MR 'classic' tests Thread-Topic: Commits breaking compilation of MR 'classic' tests Thread-Index: Ac2cD/yyF81Ny+jORaOe3pSCraIs1g== Message-ID: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.2.4.120824 acceptlanguage: en-US Content-Type: multipart/alternative; boundary="_000_CC88AB339261evansyahooinccom_" MIME-Version: 1.0 X-Milter-Version: master.31+4-gbc07cd5+ X-CLX-ID: 682075002 --_000_CC88AB339261evansyahooinccom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable That is fine, we may want to then mark it so that the MR-4687 depends on th= e JIRA to port the tests, so the tests don't disapear before we are done. --Bobby From: Arun C Murthy > Date: Wednesday, September 26, 2012 12:31 PM To: "hdfs-dev@hadoop.apache.org" >, "Yahoo! Inc." > Cc: "common-dev@hadoop.apache.org" >, "yarn-dev= @hadoop.apache.org" >, "mapreduce-dev@hadoop.apache.o= rg" > Subject: Re: Commits breaking compilation of MR 'classic' tests Fair, however there are still tests which need to be ported over. We can re= move them after the port. On Sep 26, 2012, at 9:54 AM, Robert Evans wrote: As per my comment on the bug. I though we were going to remove them. MAPREDUCE-4266 only needs a little bit more work, change a patch to a script, before they disappear entirely. I would much rather see dead code die then be maintained for a few tests that are mostly testing the dead code itself. --Bobby On 9/26/12 9:39 AM, "Arun C Murthy" > wrote: Point. I've opened https://issues.apache.org/jira/browse/MAPREDUCE-4687 to track this. On Sep 25, 2012, at 9:33 PM, Eli Collins wrote: How about adding this step to the MR PreCommit jenkins job so it's run as part test-patch? On Tue, Sep 25, 2012 at 7:48 PM, Arun C Murthy > wrote: Committers, As most people are aware, the MapReduce 'classic' tests (in hadoop-mapreduce-project/src/test) still need to built using ant since they aren't mavenized yet. I've seen several commits (and 2 within the last hour i.e. MAPREDUCE-3681 and MAPREDUCE-3682) which lead me to believe developers/committers aren't checking for this. Henceforth, with all changes, before committing, please do run: $ mvn install $ cd hadoop-mapreduce-project $ ant veryclean all-jars -Dresolvers=3Dinternal These instructions were already in http://wiki.apache.org/hadoop/HowToReleasePostMavenization and I've just updated http://wiki.apache.org/hadoop/HowToContribute. thanks, Arun -- Arun C. Murthy Hortonworks Inc. http://hortonworks.com/ -- Arun C. Murthy Hortonworks Inc. http://hortonworks.com/ --_000_CC88AB339261evansyahooinccom_--