Mailing-List: contact mapreduce-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-dev@hadoop.apache.org
Received-SPF: neutral (athena.apache.org: 216.145.54.172 is neither permitted
 nor denied by domain of evans@yahoo-inc.com)
From: Robert Evans <evans@yahoo-inc.com>
To: "hdfs-dev@hadoop.apache.org" <hdfs-dev@hadoop.apache.org>,
        "common-dev@hadoop.apache.org" <common-dev@hadoop.apache.org>,
        Eli Collins
	<eli@cloudera.com>
CC: "yarn-dev@hadoop.apache.org" <yarn-dev@hadoop.apache.org>,
        "mapreduce-dev@hadoop.apache.org" <mapreduce-dev@hadoop.apache.org>
Date: Wed, 26 Sep 2012 09:54:03 -0700
Subject: Re: Commits breaking compilation of MR 'classic' tests
Thread-Topic: Commits breaking compilation of MR 'classic' tests
Thread-Index: Ac2cB4pLhTm3QRzKTnmC1TrM7TMgpg==
Message-ID: <CC889CDB.9247%evans@yahoo-inc.com>
In-Reply-To: <EFB28CA4-A4A7-4695-B0AC-E779FFCDBA97@hortonworks.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.2.4.120824
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

As per my comment on the bug.  I though we were going to remove them.

MAPREDUCE-4266 only needs a little bit more work, change a patch to a
script, before they disappear entirely.  I would much rather see dead code
die then be maintained for a few tests that are mostly testing the dead
code itself.


--Bobby

On 9/26/12 9:39 AM, "Arun C Murthy" <acm@hortonworks.com> wrote:

>Point. I've opened https://issues.apache.org/jira/browse/MAPREDUCE-4687
>to track this.
>
>On Sep 25, 2012, at 9:33 PM, Eli Collins wrote:
>
>> How about adding this step to the MR PreCommit jenkins job so it's run
>> as part test-patch?
>>=20
>> On Tue, Sep 25, 2012 at 7:48 PM, Arun C Murthy <acm@hortonworks.com>
>>wrote:
>>> Committers,
>>>=20
>>> As most people are aware, the MapReduce 'classic' tests (in
>>>hadoop-mapreduce-project/src/test) still need to built using ant since
>>>they aren't mavenized yet.
>>>=20
>>> I've seen several commits (and 2 within the last hour i.e.
>>>MAPREDUCE-3681 and MAPREDUCE-3682) which lead me to believe
>>>developers/committers aren't checking for this.
>>>=20
>>> Henceforth, with all changes, before committing, please do run:
>>> $ mvn install
>>> $ cd hadoop-mapreduce-project
>>> $ ant veryclean all-jars -Dresolvers=3Dinternal
>>>=20
>>> These instructions were already in
>>>http://wiki.apache.org/hadoop/HowToReleasePostMavenization and I've
>>>just updated http://wiki.apache.org/hadoop/HowToContribute.
>>>=20
>>> thanks,
>>> Arun
>>>=20
>
>--
>Arun C. Murthy
>Hortonworks Inc.
>http://hortonworks.com/
>
>