hadoop-mapreduce-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun C Murthy (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (MAPREDUCE-4368) TaskRunner fails to start jars when the java.library.path contains a quoted path with embedded spaces
Date Thu, 05 Jul 2012 07:17:35 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-4368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Arun C Murthy resolved MAPREDUCE-4368.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 1-win

Looks good, +1.

I just committed this. Thanks for the patch John and Bikas/Ivan for reviews.
                
> TaskRunner fails to start jars when the java.library.path contains a quoted path with
embedded spaces
> -----------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4368
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4368
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tasktracker
>    Affects Versions: 1-win
>         Environment: on Windows: 
> set PATH=%PATH%;"C:\this memorable place".
>            Reporter: John Gordon
>            Assignee: John Gordon
>              Labels: newbie, patch
>             Fix For: 1-win
>
>         Attachments: TaskRunner.patch, TaskRunner2.patch, TaskRunner3.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> TaskRunner splits arguments by space before it adds them back to the vargs list, so it
loses all context of quote escaped strings with embedded spaces.  This gets fixed up later
by wrapping all arguments with " -- so you get something like java "-D<opt>=<value>".
 This is problematic for paths with embedded spaces, where we end up creating "-D<opt>=<first
part" "last part>".  To java, the jar being run is last part.  So with the environment
above, you will see "ClassNoDefFoundError: memorable" and the jar will fail to start.  In
this particular case, we know that java.libarary.path contains paths and the tests often use
%PATH% to seed this, so the fix is to remove embedded quotes in listed path elements because
we know the aggregate will be quoted when the JVM is started.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message