Mailing-List: contact mapreduce-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-dev@hadoop.apache.org
Date: Tue, 30 Aug 2011 14:13:39 +0000 (UTC)
From: "Robert Joseph Evans (JIRA)" <jira@apache.org>
To: mapreduce-dev@hadoop.apache.org
Message-ID: 
 <387732766.7549.1314713619714.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Created] (MAPREDUCE-2913) TestMRJobs.testFailingMapper does
 not assert the correct thing.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

TestMRJobs.testFailingMapper does not assert the correct thing.
---------------------------------------------------------------

                 Key: MAPREDUCE-2913
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2913
             Project: Hadoop Map/Reduce
          Issue Type: Bug
          Components: mrv2, test
    Affects Versions: 0.23.0, 0.24.0
            Reporter: Robert Joseph Evans
             Fix For: 0.23.0, 0.24.0


{code}
    Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
        events[0].getStatus().FAILED);
    Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
        events[1].getStatus().FAILED);
{code}

when optimized would be

{code}
    Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
        TaskCompletionEvent.Status.FAILED);
    Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
        TaskCompletionEvent.Status.FAILED);
{code}

obviously these assertions will never fail.  If we remove the {code}.FAILED{code} the asserts no longer pass. This could be because MRApp mocks out the task launcher and never actually launches anything.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira