hadoop-mapreduce-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Plamen Jeliazkov" <pjeliaz...@ebay.com>
Subject Re: Review Request: Addition of 3 new examples -- WordMean, WordMedian, and WordStandardDeviation
Date Mon, 15 Aug 2011 19:12:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1091/
-----------------------------------------------------------

(Updated 2011-08-15 19:12:56.738851)


Review request for hadoop-mapreduce.


Changes
-------

-Compressed test cases into 1 JUnit4 test case file.
-Removed need for an input file; now just reads source code files directly (math/pi set for
now).
-Other small fixes (no \\'s in file path, javac warnings, etc).


Summary
-------

Looking to add 3 new examples -- they can be added via the diff attached; some changes to
the ExamplesDriver.java might be required however these files do work alone as well. I will
also be attaching JUnit tests for these examples. I will post another review request for those.


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/examples/org/apache/hadoop/examples/WordMean.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/examples/org/apache/hadoop/examples/WordMedian.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/examples/org/apache/hadoop/examples/WordStandardDeviation.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.22/mapreduce/test/mapred/org/apache/hadoop/examples/TestWordStats.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/1091/diff


Testing
-------

JUnit tests added -- reduced to 3 tests that all read from an input folder.


Thanks,

Plamen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message