Return-Path: X-Original-To: apmail-hadoop-mapreduce-dev-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8454846F8 for ; Sun, 12 Jun 2011 18:29:54 +0000 (UTC) Received: (qmail 58853 invoked by uid 500); 12 Jun 2011 18:29:54 -0000 Delivered-To: apmail-hadoop-mapreduce-dev-archive@hadoop.apache.org Received: (qmail 58788 invoked by uid 500); 12 Jun 2011 18:29:54 -0000 Mailing-List: contact mapreduce-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-dev@hadoop.apache.org Delivered-To: mailing list mapreduce-dev@hadoop.apache.org Received: (qmail 58779 invoked by uid 99); 12 Jun 2011 18:29:54 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Jun 2011 18:29:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D9C7D1C00A9; Sun, 12 Jun 2011 18:29:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5633722346995699631==" MIME-Version: 1.0 Subject: Review Request: MAPREDUCE-397. Don't add failed TIPs back into queue after final failure. From: "Harsh J" To: "Harsh J" , "hadoop-mapreduce" Date: Sun, 12 Jun 2011 18:29:55 -0000 Message-ID: <20110612182955.13642.54562@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/887/ --===============5633722346995699631== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/887/ ----------------------------------------------------------- Review request for hadoop-mapreduce. Summary ------- In case of a task failure, the corresponding TIP is added back to the non-r= unning list via failMap()/failReduce() api. This reentry should be done onl= y for TIPs that have not failed. Reentry is useless for failed TIPs. Change checks for tip.isFailed() before proceeding. This addresses bug MAPREDUCE-397. http://issues.apache.org/jira/browse/MAPREDUCE-397 Diffs ----- src/java/org/apache/hadoop/mapred/JobInProgress.java 429d2b0 = Diff: https://reviews.apache.org/r/887/diff Testing ------- Thanks, Harsh --===============5633722346995699631==--