-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/885/#review811
-----------------------------------------------------------
Looks good. Can you upload latest patch to JIRA so QA-bot picks it up?
- Todd
On 2011-06-12 14:00:13, Harsh J wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/885/
> -----------------------------------------------------------
>
> (Updated 2011-06-12 14:00:13)
>
>
> Review request for hadoop-mapreduce.
>
>
> Summary
> -------
>
> As discussed on HADOOP-7328, MapReduce can handle serializers in a much better way in
case of bad configuration, improper imports (Some odd Text class instead of the Writable Text
set as key), etc..
>
> This issue covers the MapReduce parts of the improvements (made to MapOutputBuffer and
possible early-check of serializer availability pre-submit) that provide more information
than just an NPE as is the current case.
>
>
> This addresses bug MAPREDUCE-2584.
> http://issues.apache.org/jira/browse/MAPREDUCE-2584
>
>
> Diffs
> -----
>
> src/java/org/apache/hadoop/mapred/MapTask.java 21599c2
> src/java/org/apache/hadoop/mapreduce/JobSubmitter.java 751d528
> src/test/mapred/org/apache/hadoop/mapreduce/TestMRJobClient.java 5fa329a
>
> Diff: https://reviews.apache.org/r/885/diff
>
>
> Testing
> -------
>
> Added a test case that expects a failure if no io.serializers are present.
>
>
> Thanks,
>
> Harsh
>
>
|