hadoop-mapreduce-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon" <t...@apache.org>
Subject Re: Review Request: MAPREDUCE-2584. Check for serializers early, and give out more information regarding missing serializers.
Date Sun, 12 Jun 2011 04:39:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/885/#review808
-----------------------------------------------------------



src/java/org/apache/hadoop/mapreduce/JobSubmitter.java
<https://reviews.apache.org/r/885/#comment1770>

    ah, I noticed one more thing. This catch clause is only for the exceptions you've thrown
above.
    
    Rather than do the two nested exceptions, better to have just one layer of exceptions.
You could move the generic instructions from the lower exception to a constant and then just
append it to either of the two more specific methods above.


- Todd


On 2011-06-12 04:36:10, Harsh J wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/885/
> -----------------------------------------------------------
> 
> (Updated 2011-06-12 04:36:10)
> 
> 
> Review request for hadoop-mapreduce.
> 
> 
> Summary
> -------
> 
> As discussed on HADOOP-7328, MapReduce can handle serializers in a much better way in
case of bad configuration, improper imports (Some odd Text class instead of the Writable Text
set as key), etc..
> 
> This issue covers the MapReduce parts of the improvements (made to MapOutputBuffer and
possible early-check of serializer availability pre-submit) that provide more information
than just an NPE as is the current case.
> 
> 
> This addresses bug MAPREDUCE-2584.
>     http://issues.apache.org/jira/browse/MAPREDUCE-2584
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/hadoop/mapred/MapTask.java 21599c2 
>   src/java/org/apache/hadoop/mapreduce/JobSubmitter.java 751d528 
>   src/test/mapred/org/apache/hadoop/mapreduce/TestMRJobClient.java 5fa329a 
> 
> Diff: https://reviews.apache.org/r/885/diff
> 
> 
> Testing
> -------
> 
> Added a test case that expects a failure if no io.serializers are present.
> 
> 
> Thanks,
> 
> Harsh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message