hadoop-mapreduce-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Chen" <sc...@fb.com>
Subject Re: Review Request: MAPREDUCE-2224. Fix sync bugs in JvmManager
Date Fri, 24 Dec 2010 01:44:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/190/#review80
-----------------------------------------------------------


I like the approach. This makes the code cleaner. Just a few nitpick in line.


trunk/src/java/org/apache/hadoop/mapred/JvmManager.java
<https://reviews.apache.org/r/190/#comment137>

    This may not be necessary because one of them is immutable the other is volatile.



trunk/src/java/org/apache/hadoop/mapred/JvmManager.java
<https://reviews.apache.org/r/190/#comment135>

    Maybe we can call this setTaskRunner to make it more specific.



trunk/src/java/org/apache/hadoop/mapred/JvmManager.java
<https://reviews.apache.org/r/190/#comment136>

    Is this necessary? It seems busy is volatile.


- Scott


On 2010-12-22 12:19:22, Todd Lipcon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/190/
> -----------------------------------------------------------
> 
> (Updated 2010-12-22 12:19:22)
> 
> 
> Review request for hadoop-mapreduce and Scott Chen.
> 
> 
> Summary
> -------
> 
> See JIRA
> 
> 
> This addresses bug MAPREDUCE-2224.
>     https://issues.apache.org/jira/browse/MAPREDUCE-2224
> 
> 
> Diffs
> -----
> 
>   trunk/src/java/org/apache/hadoop/mapred/JvmManager.java 1052055 
>   trunk/src/test/mapred/org/apache/hadoop/mapred/TestJvmManager.java 1052055 
> 
> Diff: https://reviews.apache.org/r/190/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Todd
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message