hadoop-mapreduce-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ramkumar Vadali" <ramkumar.vad...@gmail.com>
Subject Re: Review Request: Refactor RaidNode to remove dependency on map reduce
Date Tue, 02 Nov 2010 22:10:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24/#review23
-----------------------------------------------------------



http://svn.apache.org/repos/asf/hadoop/mapreduce/trunk/src/contrib/raid/src/java/org/apache/hadoop/raid/RaidNode.java
<https://reviews.apache.org/r/24/#comment16>

    Can we use a dummy progressable object here instead of null?


- Ramkumar


On 2010-11-02 14:54:34, Patrick Kling wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24/
> -----------------------------------------------------------
> 
> (Updated 2010-11-02 14:54:34)
> 
> 
> Review request for hadoop-mapreduce.
> 
> 
> Summary
> -------
> 
> Refactor RaidNode to remove dependency on map reduce
> 
> I am refactoring the RaidNode code as follows: The base class RaidNode will contain the
common functionality needed for raiding files. The derived class LocalRaidNode contains an
implementation of RaidNode that performs raiding locally. The derived class DistRaidNode performs
raiding using map reduce jobs. This way, only DistRaidNode has a dependency on map reduce
code and RaidNode and LocalRaidNode can be moved to HDFS.
> 
> 
> This addresses bug MAPREDUCE-2142.
>     https://issues.apache.org/jira/browse/MAPREDUCE-2142
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/hadoop/mapreduce/trunk/src/contrib/raid/README 1030210

>   http://svn.apache.org/repos/asf/hadoop/mapreduce/trunk/src/contrib/raid/src/java/org/apache/hadoop/raid/DistRaidNode.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hadoop/mapreduce/trunk/src/contrib/raid/src/java/org/apache/hadoop/raid/Encoder.java
1030210 
>   http://svn.apache.org/repos/asf/hadoop/mapreduce/trunk/src/contrib/raid/src/java/org/apache/hadoop/raid/LocalRaidNode.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hadoop/mapreduce/trunk/src/contrib/raid/src/java/org/apache/hadoop/raid/RaidNode.java
1030210 
>   http://svn.apache.org/repos/asf/hadoop/mapreduce/trunk/src/contrib/raid/src/test/org/apache/hadoop/hdfs/TestRaidDfs.java
1030210 
>   http://svn.apache.org/repos/asf/hadoop/mapreduce/trunk/src/contrib/raid/src/test/org/apache/hadoop/raid/TestBlockFixer.java
1030210 
>   http://svn.apache.org/repos/asf/hadoop/mapreduce/trunk/src/contrib/raid/src/test/org/apache/hadoop/raid/TestRaidHar.java
1030210 
>   http://svn.apache.org/repos/asf/hadoop/mapreduce/trunk/src/contrib/raid/src/test/org/apache/hadoop/raid/TestRaidNode.java
1030210 
>   http://svn.apache.org/repos/asf/hadoop/mapreduce/trunk/src/contrib/raid/src/test/org/apache/hadoop/raid/TestRaidPurge.java
1030210 
>   http://svn.apache.org/repos/asf/hadoop/mapreduce/trunk/src/contrib/raid/src/test/org/apache/hadoop/raid/TestRaidShell.java
1030210 
> 
> Diff: https://reviews.apache.org/r/24/diff
> 
> 
> Testing
> -------
> 
> Raid unit tests
> 
> 
> Thanks,
> 
> Patrick
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message