-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20/
-----------------------------------------------------------
(Updated 2010-11-01 14:07:12.847651)
Review request for hadoop-mapreduce and Dhruba Borthakur.
Changes
-------
Fixed some comments I'd copied over but left unchanged.
Summary
-------
Extend TaskTrackerStatus.ResourceStatus and ResourceCalculatorPlugin to allow for sending
last-one-minute load average reports.
Here's a link on load and how they could help with scheduling: http://en.wikipedia.org/wiki/Load_(computing)
This addresses bug MAPREDUCE-2170.
https://issues.apache.org/jira/browse/MAPREDUCE-2170
Diffs (updated)
-----
/trunk/src/java/org/apache/hadoop/mapred/TaskTrackerStatus.java 1029240
/trunk/src/java/org/apache/hadoop/mapreduce/util/LinuxResourceCalculatorPlugin.java 1029240
/trunk/src/java/org/apache/hadoop/mapreduce/util/ResourceCalculatorPlugin.java 1029240
/trunk/src/test/mapred/org/apache/hadoop/mapred/DummyResourceCalculatorPlugin.java 1029240
/trunk/src/test/mapred/org/apache/hadoop/mapred/TestTTResourceReporting.java 1029240
/trunk/src/test/mapred/org/apache/hadoop/mapreduce/util/TestLinuxResourceCalculatorPlugin.java
1029240
Diff: https://reviews.apache.org/r/20/diff
Testing
-------
/proc/loadavg is available on all GNU/Linux systems.
Post editing and recompiling, "ant clean; ant test" passes.
I've added a test case for the Linux plugin, and also extended the existing TT Reporting test
to beam out and receive load averages. Please let me know if I need to add any more tests.
Thanks,
Harsh
|