hadoop-mapreduce-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From acmur...@apache.org
Subject svn commit: r1169955 - in /hadoop/common/trunk/hadoop-mapreduce-project: ./ hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/
Date Mon, 12 Sep 2011 21:53:51 GMT
Author: acmurthy
Date: Mon Sep 12 21:53:51 2011
New Revision: 1169955

URL: http://svn.apache.org/viewvc?rev=1169955&view=rev
Log:
MAPREDUCE-2985. Fixed findbugs warnings in ResourceLocalizationService. Contributed by Thomas
Graves.

Modified:
    hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
    hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java

Modified: hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt?rev=1169955&r1=1169954&r2=1169955&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt Mon Sep 12 21:53:51 2011
@@ -1296,6 +1296,9 @@ Release 0.23.0 - Unreleased
    MAPREDUCE-2979. Removed the needless ClientProtocolProvider configuration
    from the hadoop-mapreduce-client-core module. (Siddharth Seth via vinodkv)
 
+   MAPREDUCE-2985. Fixed findbugs warnings in ResourceLocalizationService.
+   (Thomas Graves via acmurthy)
+
 Release 0.22.0 - Unreleased
 
   INCOMPATIBLE CHANGES

Modified: hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java?rev=1169955&r1=1169954&r2=1169955&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
(original)
+++ hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
Mon Sep 12 21:53:51 2011
@@ -289,11 +289,12 @@ public class ResourceLocalizationService
       LocalizerContext ctxt = new LocalizerContext(
           c.getUser(), c.getContainerID(), c.getCredentials());
       rsrcs = rsrcReqs.getRequestedResources();
-      for (LocalResourceVisibility vis : rsrcs.keySet()) {
-        tracker = getLocalResourcesTracker(vis, c.getUser(), 
+      for (Map.Entry<LocalResourceVisibility, Collection<LocalResourceRequest>>
e :
+           rsrcs.entrySet()) {
+        tracker = getLocalResourcesTracker(e.getKey(), c.getUser(), 
             c.getContainerID().getAppId());
-        for (LocalResourceRequest req : rsrcs.get(vis)) {
-          tracker.handle(new ResourceRequestEvent(req, vis, ctxt));
+        for (LocalResourceRequest req : e.getValue()) {
+          tracker.handle(new ResourceRequestEvent(req, e.getKey(), ctxt));
         }
       }
       break;
@@ -312,10 +313,11 @@ public class ResourceLocalizationService
         (ContainerLocalizationCleanupEvent) event;
       c = rsrcCleanup.getContainer();
       rsrcs = rsrcCleanup.getResources();
-      for (LocalResourceVisibility vis : rsrcs.keySet()) {
-        tracker = getLocalResourcesTracker(vis, c.getUser(), 
+      for (Map.Entry<LocalResourceVisibility, Collection<LocalResourceRequest>>
e :
+           rsrcs.entrySet()) {
+        tracker = getLocalResourcesTracker(e.getKey(), c.getUser(), 
             c.getContainerID().getAppId());
-        for (LocalResourceRequest req : rsrcs.get(vis)) {
+        for (LocalResourceRequest req : e.getValue()) {
           tracker.handle(new ResourceReleaseEvent(req, c.getContainerID()));
         }
       }



Mime
View raw message