hadoop-mapreduce-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omal...@apache.org
Subject svn commit: r1079210 - /hadoop/mapreduce/branches/yahoo-merge/src/java/org/apache/hadoop/mapred/Task.java
Date Tue, 08 Mar 2011 05:56:07 GMT
Author: omalley
Date: Tue Mar  8 05:56:07 2011
New Revision: 1079210

URL: http://svn.apache.org/viewvc?rev=1079210&view=rev
Log:
commit bdd6d8d8d7214c34555b9264f680b0c7b6548491
Author: Greg Roelofs <roelofs@yahoo-inc.com>
Date:   Wed Dec 8 18:15:53 2010 -0800

    Removing debug printfs for committable "v8b" patch.

Modified:
    hadoop/mapreduce/branches/yahoo-merge/src/java/org/apache/hadoop/mapred/Task.java

Modified: hadoop/mapreduce/branches/yahoo-merge/src/java/org/apache/hadoop/mapred/Task.java
URL: http://svn.apache.org/viewvc/hadoop/mapreduce/branches/yahoo-merge/src/java/org/apache/hadoop/mapred/Task.java?rev=1079210&r1=1079209&r2=1079210&view=diff
==============================================================================
--- hadoop/mapreduce/branches/yahoo-merge/src/java/org/apache/hadoop/mapred/Task.java (original)
+++ hadoop/mapreduce/branches/yahoo-merge/src/java/org/apache/hadoop/mapred/Task.java Tue
Mar  8 05:56:07 2011
@@ -1011,7 +1011,6 @@ abstract public class Task implements Wr
       try {
         while (!umbilical.canCommit(taskIdForUmbilical)) {
           try {
-System.out.println("GRR DEBUG:  Task commitAfterApproval(): TT canCommit() returned false;
sleeping 1 sec");
             // FIXME 1:  shouldn't this count down retries, too, in case JT glitched and
no longer knows about us?  (else infinite loop)
             Thread.sleep(1000);  // FIXME 2:  shouldn't hardcoded 1-second sleep instead
correspond to heartbeat interval for task?
           } catch(InterruptedException ie) {
@@ -1019,10 +1018,8 @@ System.out.println("GRR DEBUG:  Task com
           }
           reporter.setProgressFlag();
         }
-System.out.println("GRR DEBUG:  Task commitAfterApproval(): TT canCommit() returned true");
         break;
       } catch (IOException ie) {
-System.out.println("GRR DEBUG:  Task commitAfterApproval(): TT canCommit() threw exception");
         LOG.warn("Failure asking whether task can commit: " +
             StringUtils.stringifyException(ie));
         if (--retries == 0) {
@@ -1040,7 +1037,6 @@ System.out.println("GRR DEBUG:  Task com
   // this is protected (rather than private) solely for UberTask map-only case
   protected void commit(TaskUmbilicalProtocol umbilical,
                         TaskReporter reporter) throws IOException {
-System.out.println("GRR DEBUG:  Task commit(): about to call commitTask()");
     try {
       LOG.info("Task " + taskId + " is allowed to commit now");
       committer.commitTask(taskContext);



Mime
View raw message