Return-Path: Delivered-To: apmail-hadoop-mapreduce-commits-archive@minotaur.apache.org Received: (qmail 88688 invoked from network); 9 Sep 2009 21:07:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 9 Sep 2009 21:07:15 -0000 Received: (qmail 50805 invoked by uid 500); 9 Sep 2009 21:07:15 -0000 Delivered-To: apmail-hadoop-mapreduce-commits-archive@hadoop.apache.org Received: (qmail 50759 invoked by uid 500); 9 Sep 2009 21:07:14 -0000 Mailing-List: contact mapreduce-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-dev@hadoop.apache.org Delivered-To: mailing list mapreduce-commits@hadoop.apache.org Received: (qmail 50743 invoked by uid 99); 9 Sep 2009 21:07:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Sep 2009 21:07:14 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Sep 2009 21:07:11 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 9536D238889D; Wed, 9 Sep 2009 21:06:50 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r813116 - in /hadoop/mapreduce/trunk: CHANGES.txt src/java/org/apache/hadoop/mapreduce/lib/input/KeyValueLineRecordReader.java Date: Wed, 09 Sep 2009 21:06:50 -0000 To: mapreduce-commits@hadoop.apache.org From: cdouglas@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090909210650.9536D238889D@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: cdouglas Date: Wed Sep 9 21:06:50 2009 New Revision: 813116 URL: http://svn.apache.org/viewvc?rev=813116&view=rev Log: MAPREDUCE-960. Remove an unnecessary intermediate copy and obsolete API from KeyValueLineRecordReader. Modified: hadoop/mapreduce/trunk/CHANGES.txt hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapreduce/lib/input/KeyValueLineRecordReader.java Modified: hadoop/mapreduce/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/mapreduce/trunk/CHANGES.txt?rev=813116&r1=813115&r2=813116&view=diff ============================================================================== --- hadoop/mapreduce/trunk/CHANGES.txt (original) +++ hadoop/mapreduce/trunk/CHANGES.txt Wed Sep 9 21:06:50 2009 @@ -315,6 +315,9 @@ replace it with o.a.h.fs.FileAlreadyExistsException. (Boris Shkolnik via szetszwo) + MAPREDUCE-960. Remove an unnecessary intermediate copy and obsolete API + from KeyValueLineRecordReader. (cdouglas) + BUG FIXES MAPREDUCE-878. Rename fair scheduler design doc to Modified: hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapreduce/lib/input/KeyValueLineRecordReader.java URL: http://svn.apache.org/viewvc/hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapreduce/lib/input/KeyValueLineRecordReader.java?rev=813116&r1=813115&r2=813116&view=diff ============================================================================== --- hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapreduce/lib/input/KeyValueLineRecordReader.java (original) +++ hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapreduce/lib/input/KeyValueLineRecordReader.java Wed Sep 9 21:06:50 2009 @@ -44,8 +44,6 @@ private Text value; - public Class getKeyClass() { return Text.class; } - public KeyValueLineRecordReader(Configuration conf) throws IOException { @@ -75,14 +73,8 @@ key.set(line, 0, lineLen); value.set(""); } else { - int keyLen = pos; - byte[] keyBytes = new byte[keyLen]; - System.arraycopy(line, 0, keyBytes, 0, keyLen); - int valLen = lineLen - keyLen - 1; - byte[] valBytes = new byte[valLen]; - System.arraycopy(line, pos + 1, valBytes, 0, valLen); - key.set(keyBytes); - value.set(valBytes); + key.set(line, 0, pos); + value.set(line, pos + 1, lineLen - pos - 1); } } /** Read key/value pair in a line. */