hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
Date Mon, 20 Sep 2010 19:14:33 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912652#action_12912652
] 

HBase Review Board commented on HIVE-1378:
------------------------------------------

Message from: "Steven Wong" <skwslide@gmail.com>


bq.  On 2010-09-17 23:09:15, Ning Zhang wrote:
bq.  > Looks good in general. Some minor comments. I'll also ask Zheng to review it.

Thanks for taking the time to review it! See my comments below.


bq.  On 2010-09-17 23:09:15, Ning Zhang wrote:
bq.  > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 288
bq.  > <http://review.cloudera.org/r/828/diff/2/?file=11939#file11939line288>
bq.  >
bq.  >     Can you also add this parameter to conf/hive-default.xml? This file should contain
all user-tunable parameters in HiveConf.java.

Will add.


bq.  On 2010-09-17 23:09:15, Ning Zhang wrote:
bq.  > trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java, line 158
bq.  > <http://review.cloudera.org/r/828/diff/2/?file=11942#file11942line158>
bq.  >
bq.  >     check null first?

Ditto.


bq.  On 2010-09-17 23:09:15, Ning Zhang wrote:
bq.  > trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java, line 140
bq.  > <http://review.cloudera.org/r/828/diff/2/?file=11942#file11942line140>
bq.  >
bq.  >     should null be checked first?

This is copied from the existing code of getInt/getDouble/etc. Null doesn't have to be checked
first because X.class.isInstance(obj) handles null obj correctly, i.e. X.class.isInstance(null)
is false. My guess is, X.class.isInstance(obj) is checked first because the original coder
assumes obj is more likely to be non-null.


- Steven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/828/#review1269
-----------------------------------------------------------





> Return value for map, array, and struct needs to return a string 
> -----------------------------------------------------------------
>
>                 Key: HIVE-1378
>                 URL: https://issues.apache.org/jira/browse/HIVE-1378
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Drivers
>            Reporter: Jerome Boulon
>            Assignee: Steven Wong
>             Fix For: 0.7.0
>
>         Attachments: HIVE-1378.1.patch, HIVE-1378.patch
>
>
> In order to be able to select/display any data from JDBC Hive driver, return value for
map, array, and struct needs to return a string

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message