hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-1609) Support partition filtering in metastore
Date Thu, 02 Sep 2010 03:00:54 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905383#action_12905383
] 

HBase Review Board commented on HIVE-1609:
------------------------------------------

Message from: "Carl Steinbach" <carl@cloudera.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/763/#review1075
-----------------------------------------------------------



trunk/metastore/build.xml
<http://review.cloudera.org/r/763/#comment3422>

    Hive already uses ANTLR. Introducing a dependency on a new parser generator (especially
one that the Pig devs are already unhappy with) seems unwise from a maintenance and build
perspective. Can you please rewrite this to use ANTLR?
    



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<http://review.cloudera.org/r/763/#comment3424>

    get_partitions_by_filter() should throw Unknown[DB|Table]Exception if either the database
or table do not exist.



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
<http://review.cloudera.org/r/763/#comment3425>

    listPartitionsByFilter() should also throw UnknownDBException and UnknownTableException.



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
<http://review.cloudera.org/r/763/#comment3426>

    Please use StringBuilder instead.



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
<http://review.cloudera.org/r/763/#comment3427>

    The query should have an ORDER clause on MPartition.partitionName in order to insure that
the results are deterministic.



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
<http://review.cloudera.org/r/763/#comment3428>

    Minor organization issue: why does this method appear here instead of next to listMPartitionsByFilter()?


- Carl





> Support partition filtering in metastore
> ----------------------------------------
>
>                 Key: HIVE-1609
>                 URL: https://issues.apache.org/jira/browse/HIVE-1609
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Metastore
>            Reporter: Ajay Kidave
>             Fix For: 0.7.0
>
>         Attachments: hive_1609.patch
>
>
> The metastore needs to have support for returning a list of partitions based on user
specified filter conditions. This will be useful for tools which need to do partition pruning.
Howl is one such use case. The way partition pruning is done during hive query execution need
not be changed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message