hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zheng Shao" <zsh...@gmail.com>
Subject Re: Review Request: HIVE-537 Hive TypeInfo/ObjectInspector to support union (besides struct, array, and map)
Date Wed, 15 Sep 2010 22:15:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/795/#review1231
-----------------------------------------------------------


Overall looks like a good first step.  We need to change Hive.g, add UDF etc to allow users
to use it in the Hive language.


trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java
<http://review.cloudera.org/r/795/#comment4192>

    unioin -> union



trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
<http://review.cloudera.org/r/795/#comment4193>

    We cannot compare 2 union objects like this.  We need to first compare their TAG.  Only
when the TAG is the same shall we compare the field.


- Zheng


On 2010-09-07 02:59:54, Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/795/
> -----------------------------------------------------------
> 
> (Updated 2010-09-07 02:59:54)
> 
> 
> Review request for Hive Developers.
> 
> 
> Summary
> -------
> 
> Adds Union type to Standard ObjectInSpectors, TypeInfo and Lazy ObjectInspectors.
> 
> 
> This addresses bug HIVE-537.
>     http://issues.apache.org/jira/browse/HIVE-537
> 
> 
> Diffs
> -----
> 
>   trunk/serde/src/gen-java/org/apache/hadoop/hive/serde/Constants.java 991812 
>   trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 991812 
>   trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java
991812 
>   trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java 991812 
>   trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 991812

>   trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUnion.java PRE-CREATION

>   trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
991812 
>   trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyUnionObjectInspector.java
PRE-CREATION 
>   trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspector.java
991812 
>   trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java
991812 
>   trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
991812 
>   trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardUnionObjectInspector.java
PRE-CREATION 
>   trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionObject.java
PRE-CREATION 
>   trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionObjectInspector.java
PRE-CREATION 
>   trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java 991812 
>   trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java 991812

>   trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 991812

>   trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/UnionTypeInfo.java PRE-CREATION

>   trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyArrayMapStruct.java
991812 
>   trunk/serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java
991812 
> 
> Diff: http://review.cloudera.org/r/795/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Amareshwari
> 
>


Mime
View raw message