hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
Date Thu, 23 Sep 2010 20:59:33 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914222#action_12914222
] 

HBase Review Board commented on HIVE-1378:
------------------------------------------

Message from: "Steven Wong" <skwslide@gmail.com>


bq.  On 2010-09-22 12:01:30, Ning Zhang wrote:
bq.  > trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java, line 168
bq.  > <http://review.cloudera.org/r/828/diff/4/?file=12387#file12387line168>
bq.  >
bq.  >     constructing an ArrayList for every row is very expensive. Do you need a separate
copy every row or can share a "cache" among rows?

I will move the ArrayList construction to HiveQueryResultSet's constructor.


bq.  On 2010-09-22 12:01:30, Ning Zhang wrote:
bq.  > trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java, line
409
bq.  > <http://review.cloudera.org/r/828/diff/4/?file=12399#file12399line409>
bq.  >
bq.  >     Removing this changes the behavior: previously it throws an exception and schema
mismatch, not it tolerate it. It would be good to remain backward compatibility.

Yeah. I don't believe the removal is necessary, and will put it back.


- Steven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/828/#review1296
-----------------------------------------------------------





> Return value for map, array, and struct needs to return a string 
> -----------------------------------------------------------------
>
>                 Key: HIVE-1378
>                 URL: https://issues.apache.org/jira/browse/HIVE-1378
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Drivers
>            Reporter: Jerome Boulon
>            Assignee: Steven Wong
>             Fix For: 0.7.0
>
>         Attachments: HIVE-1378.1.patch, HIVE-1378.2.patch, HIVE-1378.3.patch, HIVE-1378.4.patch,
HIVE-1378.patch
>
>
> In order to be able to select/display any data from JDBC Hive driver, return value for
map, array, and struct needs to return a string

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message