hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sichi (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar
Date Sat, 28 Aug 2010 00:39:54 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903738#action_12903738
] 

John Sichi commented on HIVE-1546:
----------------------------------

Yes, that is what I was envisioning.  I think the interface as you've specified it looks close
to the abstract functionality of the semantic analyzer, which is what we want (although we
should use interfaces such as Set in preference to concrete classes such as HashSet, something
which is currently crufty throughout Hive).

I agree that this could be too involved for your first patch, and we would probably need to
evolve the HiveSemanticAnalyzer interface anyway.  So, if you're not comfortable going there,
let's scale it back to the approach in the first patch (with HiveSemanticAnalyzerFactory returning
BaseSemanticAnalyzer).

handleGenericFileFormat:  if it's only a hook for Howl, then you can have a separate method
inside of Howl which returns whatever you want, but wrap it with a void method which overrides
a void one in Hive (and discards the return values).  Or, if the idea is to have Hive use
this too, then go ahead and add Javadoc specifying exactly what the return map is supposed
to contain, and then convert the existing SEQUENCEFILE/TEXTFILE/RCFILE cases so they go through
the generic path.  (But still keep them as reserved words rather than literal strings for
backwards compatibility.)


> Ability to plug custom Semantic Analyzers for Hive Grammar
> ----------------------------------------------------------
>
>                 Key: HIVE-1546
>                 URL: https://issues.apache.org/jira/browse/HIVE-1546
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 0.7.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.7.0
>
>         Attachments: hive-1546.patch, hive-1546_2.patch
>
>
> It will be useful if Semantic Analysis phase is made pluggable such that other projects
can do custom analysis of hive queries before doing metastore operations on them. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message