hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <c...@cloudera.com>
Subject Re: Review Request: HIVE-675: Add database/scheme support Hive QL
Date Tue, 24 Aug 2010 20:56:27 GMT


> On 2010-08-17 15:32:59, namit jain wrote:
> > metastore/src/model/package.jdo, line 14
> > <http://review.cloudera.org/r/508/diff/4/?file=7227#file7227line14>
> >
> >     Why do you want to change the field name ?

I changed it since this refers to the value of the COMMENT clause in the CREATE DATABASE statement.
I changed it back to the original value just to keep things simple.


- Carl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/508/#review934
-----------------------------------------------------------


On 2010-08-24 13:55:16, Carl Steinbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/508/
> -----------------------------------------------------------
> 
> (Updated 2010-08-24 13:55:16)
> 
> 
> Review request for Hive Developers.
> 
> 
> Summary
> -------
> 
> Database/Scheme support for Hive.
> 
> * Implemented 'SHOW DATABASES' command
> * Refactored TestHiveMetaStore and enabled tests for remote metastore client.
> * Added launch configurations for TestHiveMetaStore and TestHiveMetaStoreRemote
> 
> 
> This addresses bug HIVE-675.
>     http://issues.apache.org/jira/browse/HIVE-675
> 
> 
> Diffs
> -----
> 
>   .gitignore 376cdc6 
>   build-common.xml 00aa470 
>   eclipse-templates/TestCliDriver.launchtemplate c304161 
>   eclipse-templates/TestEmbeddedHiveMetaStore.launchtemplate PRE-CREATION 
>   eclipse-templates/TestHive.launchtemplate 24efc12 
>   eclipse-templates/TestHiveMetaStoreChecker.launchtemplate PRE-CREATION 
>   eclipse-templates/TestRemoteHiveMetaStore.launchtemplate PRE-CREATION 
>   metastore/if/hive_metastore.thrift 478d0af 
>   metastore/src/gen-cpp/ThriftHiveMetastore.h e2538fb 
>   metastore/src/gen-cpp/ThriftHiveMetastore.cpp f945a3a 
>   metastore/src/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp ed2bb99 
>   metastore/src/gen-cpp/hive_metastore_types.h 1b0c706 
>   metastore/src/gen-cpp/hive_metastore_types.cpp b5a403d 
>   metastore/src/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java 78c78d9

>   metastore/src/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
25408d9 
>   metastore/src/gen-php/ThriftHiveMetastore.php ea4add5 
>   metastore/src/gen-php/hive_metastore_types.php 61872a0 
>   metastore/src/gen-py/hive_metastore/ThriftHiveMetastore-remote fc06cba 
>   metastore/src/gen-py/hive_metastore/ThriftHiveMetastore.py 4a0bc67 
>   metastore/src/gen-py/hive_metastore/ttypes.py ea7269e 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 39dbd52 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 4fb296a 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java c6541af

>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 6013644 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 0818689 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java a06384c 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 4951bd6 
>   metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 4488f94 
>   metastore/src/model/org/apache/hadoop/hive/metastore/model/MDatabase.java b3e098d 
>   metastore/src/model/package.jdo 206ba75 
>   metastore/src/test/org/apache/hadoop/hive/metastore/TestEmbeddedHiveMetaStore.java
PRE-CREATION 
>   metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java fff6aad

>   metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreRemote.java bc950b9

>   metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 28b4d2a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java d59f48c 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ce5d903 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 352af89 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java eedf9e3 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 658eea5 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g fca7ff6 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cba4a66 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 881290c 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateDatabaseDesc.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 0c848e6 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ShowDatabasesDesc.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/SwitchDatabaseDesc.java PRE-CREATION 
>   ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java 70d64ef 
>   ql/src/test/org/apache/hadoop/hive/ql/hooks/EnforceReadOnlyTables.java 8cff958 
>   ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java ab39ca4 
>   ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreChecker.java 26cc71a

>   ql/src/test/org/apache/hadoop/hive/ql/metadata/TestPartition.java 790abf6 
>   ql/src/test/queries/clientnegative/database_create_already_exists.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/database_create_invalid_name.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/database_drop_does_not_exist.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/database_drop_not_empty.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/database_switch_does_not_exist.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/add_part_exist.q 54d0096 
>   ql/src/test/queries/clientpositive/alter1.q 6f95685 
>   ql/src/test/queries/clientpositive/alter2.q 2388e21 
>   ql/src/test/queries/clientpositive/alter3.q d9d3b07 
>   ql/src/test/queries/clientpositive/alter4.q 35fa441 
>   ql/src/test/queries/clientpositive/database.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/rename_column.q ce82ff7 
>   ql/src/test/results/clientnegative/database_already_exists.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/database_create_already_exists.q.out PRE-CREATION

>   ql/src/test/results/clientnegative/database_create_invalid_name.q.out PRE-CREATION

>   ql/src/test/results/clientnegative/database_drop_does_not_exist.q.out PRE-CREATION

>   ql/src/test/results/clientnegative/database_drop_not_empty.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/database_switch_does_not_exist.q.out PRE-CREATION

>   ql/src/test/results/clientpositive/add_part_exist.q.out 5f76c9d 
>   ql/src/test/results/clientpositive/alter1.q.out 73c5978 
>   ql/src/test/results/clientpositive/alter2.q.out 06a2bab 
>   ql/src/test/results/clientpositive/alter3.q.out 3f91306 
>   ql/src/test/results/clientpositive/alter4.q.out 058d25d 
>   ql/src/test/results/clientpositive/database.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/rename_column.q.out 252d681 
> 
> Diff: http://review.cloudera.org/r/508/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Carl
> 
>


Mime
View raw message