hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sichi (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-1126) Missing some Jdbc functionality like getTables getColumns and HiveResultSet.get* methods based on column name.
Date Thu, 22 Jul 2010 20:13:56 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891312#action_12891312
] 

John Sichi commented on HIVE-1126:
----------------------------------

Regarding the synchronization:  Squirrel really should not be calling onto multiple objects
from the same JDBC connections from different threads (except in the special case of cancel).
 In general, JDBC drivers don't make a guarantee of thread safety within the same connection.

If it is expecting this guarantee, then in general the synchronization would need to be added
at a higher level (on the JDBC connection object itself, regardless of which object is receiving
the API call) since over time we could be adding more client-side state.

Creating a new client connection is not a good approach since we want the session state shared
within a connection.

I suggest we get the current work committed without any synchronization, and then open up
a separate JIRA to investigate further.

Regarding Carl's review comments:  all of them look correct to me, so could you take care
of them as part of the next rev of the patch?

> Missing some Jdbc functionality like getTables getColumns and HiveResultSet.get* methods
based on column name.
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-1126
>                 URL: https://issues.apache.org/jira/browse/HIVE-1126
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Clients
>    Affects Versions: 0.7.0
>            Reporter: Bennie Schut
>            Assignee: Bennie Schut
>            Priority: Minor
>             Fix For: 0.7.0
>
>         Attachments: HIVE-1126-1.patch, HIVE-1126-2.patch, HIVE-1126.patch, HIVE-1126_patch(0.5.0_source).patch
>
>
> I've been using the hive jdbc driver more and more and was missing some functionality
which I added
> HiveDatabaseMetaData.getTables
> Using "show tables" to get the info from hive.
> HiveDatabaseMetaData.getColumns
> Using "describe tablename" to get the columns.
> This makes using something like SQuirreL a lot nicer since you have the list of tables
and just click on the content tab to see what's in the table.
> I also implemented
> HiveResultSet.getObject(String columnName) so you call most get* methods based on the
column name.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message