hadoop-hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sichi (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-1359) Unit test should be shim-aware
Date Tue, 22 Jun 2010 18:28:54 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881285#action_12881285
] 

John Sichi commented on HIVE-1359:
----------------------------------

Since we're not actually dealing with the minimr requirement in this patch, probably better
to just leave out those changes completely and we'll address them in HIVE-117.  In particular,
I don't think the cluster mode should be part of the test code generation; we want it completely
dynamic so that we re-run the same test in either mode without regenerating code.

Minor nitpicks (these can be fixed in the followup instead of now):

* hadoopVersion = new String("") is the same as hadoopVersion = ""

* usage of Stack is deprecated since it is based on synchronized Vector


> Unit test should be shim-aware
> ------------------------------
>
>                 Key: HIVE-1359
>                 URL: https://issues.apache.org/jira/browse/HIVE-1359
>             Project: Hadoop Hive
>          Issue Type: New Feature
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ning Zhang
>            Assignee: Ning Zhang
>             Fix For: 0.6.0, 0.7.0
>
>         Attachments: HIVE-1359.patch, unit_tests.txt
>
>
> Some features in Hive only works for certain Hadoop versions through shim. However the
unit test structure is not shim-aware in that there is only one set of queries and expected
outputs for all Hadoop versions. This may not be sufficient when we will have different output
for different Hadoop versions. One example is CombineHiveInputFormat wich is only available
from Hadoop 0.20. The plan using CombineHiveInputFormat and HiveInputFormat may be different.
Another example is archival partitions (HAR) which is also only available from 0.20. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message